Discussion:
Review Request 130056: Selection text shows floating point rounding errors
Lukas Hetzenecker
2017-03-29 07:50:38 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130056/
-----------------------------------------------------------

Review request for KDE Graphics and Boudhayan Gupta.


Repository: spectacle


Description
-------

When a non-integer scale factor is used, the `selection.width * Screen.devicePixelRatio` calculation results in a floating-point multiplication and therefore needs to be rounded up before shown


Diffs
-----

src/QuickEditor/EditorRoot.qml 8a5fc49

Diff: https://git.reviewboard.kde.org/r/130056/diff/


Testing
-------

Selected area for screenshot on a 1.8 scale factor.


File Attachments
----------------

Screenshot_20170329_094106.png
Loading Image...


Thanks,

Lukas Hetzenecker
Boudhayan Gupta
2017-03-29 13:40:40 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130056/#review102970
-----------------------------------------------------------


Ship it!




Ship It!

- Boudhayan Gupta
Post by Lukas Hetzenecker
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130056/
-----------------------------------------------------------
(Updated March 29, 2017, 1:20 p.m.)
Review request for KDE Graphics and Boudhayan Gupta.
Repository: spectacle
Description
-------
When a non-integer scale factor is used, the `selection.width * Screen.devicePixelRatio` calculation results in a floating-point multiplication and therefore needs to be rounded up before shown
Diffs
-----
src/QuickEditor/EditorRoot.qml 8a5fc49
Diff: https://git.reviewboard.kde.org/r/130056/diff/
Testing
-------
Selected area for screenshot on a 1.8 scale factor.
File Attachments
----------------
Screenshot_20170329_094106.png
https://git.reviewboard.kde.org/media/uploaded/files/2017/03/29/5655660f-e8c9-4f07-b6a0-0509d9ba17a0__Screenshot_20170329_094106.png
Thanks,
Lukas Hetzenecker
Lukas Hetzenecker
2017-03-29 13:47:38 UTC
Permalink
Post by Lukas Hetzenecker
Post by Boudhayan Gupta
Ship It!
I unfortunately don't have a Developer Account yet, could you submit it on my behalf? Thanks


- Lukas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130056/#review102970
-----------------------------------------------------------
Post by Lukas Hetzenecker
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130056/
-----------------------------------------------------------
(Updated March 29, 2017, 7:50 a.m.)
Review request for KDE Graphics and Boudhayan Gupta.
Repository: spectacle
Description
-------
When a non-integer scale factor is used, the `selection.width * Screen.devicePixelRatio` calculation results in a floating-point multiplication and therefore needs to be rounded up before shown
Diffs
-----
src/QuickEditor/EditorRoot.qml 8a5fc49
Diff: https://git.reviewboard.kde.org/r/130056/diff/
Testing
-------
Selected area for screenshot on a 1.8 scale factor.
File Attachments
----------------
Screenshot_20170329_094106.png
https://git.reviewboard.kde.org/media/uploaded/files/2017/03/29/5655660f-e8c9-4f07-b6a0-0509d9ba17a0__Screenshot_20170329_094106.png
Thanks,
Lukas Hetzenecker
Lukas Hetzenecker
2017-03-29 22:49:38 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130056/
-----------------------------------------------------------

(Updated March 29, 2017, 10:49 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Graphics and Boudhayan Gupta.


Changes
-------

Submitted with commit 5e53ca16d61940e979f33c3650fd7db1bd695b80 by Albert Astals Cid on behalf of Lukas Hetzenecker to branch Applications/17.04.


Repository: spectacle


Description
-------

When a non-integer scale factor is used, the `selection.width * Screen.devicePixelRatio` calculation results in a floating-point multiplication and therefore needs to be rounded up before shown


Diffs
-----

src/QuickEditor/EditorRoot.qml 8a5fc49

Diff: https://git.reviewboard.kde.org/r/130056/diff/


Testing
-------

Selected area for screenshot on a 1.8 scale factor.


File Attachments
----------------

Screenshot_20170329_094106.png
https://git.reviewboard.kde.org/media/uploaded/files/2017/03/29/5655660f-e8c9-4f07-b6a0-0509d9ba17a0__Screenshot_20170329_094106.png


Thanks,

Lukas Hetzenecker

Loading...