Discussion:
[Kde-graphics-devel] Review Request 128404: add simple appdata file
Burkhard Lück
2016-07-08 07:32:39 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128404/
-----------------------------------------------------------

Review request for KDE Graphics and Albert Astals Cid.


Repository: okular


Description
-------

verified with appstreamcli validate


Diffs
-----

shell/CMakeLists.txt d51cc7e
shell/org.kde.okular.appdata.xml PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/128404/diff/


Testing
-------

builds


Thanks,

Burkhard LÃŒck
Aleix Pol Gonzalez
2016-07-08 13:35:35 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128404/#review97214
-----------------------------------------------------------



+1 lgtm

Will have to add one for each plugin as discussed in bug 363842.

- Aleix Pol Gonzalez
Post by Burkhard Lück
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/128404/
-----------------------------------------------------------
(Updated July 8, 2016, 9:32 a.m.)
Review request for KDE Graphics and Albert Astals Cid.
Repository: okular
Description
-------
verified with appstreamcli validate
Diffs
-----
shell/CMakeLists.txt d51cc7e
shell/org.kde.okular.appdata.xml PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/128404/diff/
Testing
-------
builds
Thanks,
Burkhard LÃŒck
Burkhard Lück
2016-08-24 08:34:48 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128404/
-----------------------------------------------------------

(Updated Aug. 24, 2016, 8:34 vorm.)


Review request for KDE Graphics and Albert Astals Cid.


Summary (updated)
-----------------

add simple appdata file + metadata for chm, comicbook, djvu, dvi, epub, fax, fictionbook


Repository: okular


Description
-------

verified with appstreamcli validate


Diffs (updated)
-----

generators/chm/CMakeLists.txt e54affc
generators/chm/okular-chm.metainfo.xml PRE-CREATION
generators/comicbook/CMakeLists.txt 4df23a6
generators/comicbook/okular-comicbook.metainfo.xml PRE-CREATION
generators/djvu/CMakeLists.txt 8ca545c
generators/djvu/okular-djvu.metainfo.xml PRE-CREATION
generators/dvi/CMakeLists.txt e95c9ca
generators/dvi/okular-dvi.metainfo.xml PRE-CREATION
generators/epub/CMakeLists.txt fa989ad
generators/epub/okular-epub.metainfo.xml PRE-CREATION
generators/fax/CMakeLists.txt f3a321c
generators/fax/okular-fax.metainfo.xml PRE-CREATION
generators/fictionbook/CMakeLists.txt 108568b
generators/fictionbook/okular-fb.metainfo.xml PRE-CREATION
shell/CMakeLists.txt d51cc7e
shell/org.kde.okular.appdata.xml PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/128404/diff/


Testing
-------

builds


Thanks,

Burkhard LÃŒck
Aleix Pol Gonzalez
2016-11-01 18:20:20 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128404/#review100477
-----------------------------------------------------------


Ship it!




Let's give it a try!

- Aleix Pol Gonzalez
Post by Burkhard Lück
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/128404/
-----------------------------------------------------------
(Updated Aug. 24, 2016, 10:34 a.m.)
Review request for KDE Graphics and Albert Astals Cid.
Repository: okular
Description
-------
verified with appstreamcli validate
Diffs
-----
generators/chm/CMakeLists.txt e54affc
generators/chm/okular-chm.metainfo.xml PRE-CREATION
generators/comicbook/CMakeLists.txt 4df23a6
generators/comicbook/okular-comicbook.metainfo.xml PRE-CREATION
generators/djvu/CMakeLists.txt 8ca545c
generators/djvu/okular-djvu.metainfo.xml PRE-CREATION
generators/dvi/CMakeLists.txt e95c9ca
generators/dvi/okular-dvi.metainfo.xml PRE-CREATION
generators/epub/CMakeLists.txt fa989ad
generators/epub/okular-epub.metainfo.xml PRE-CREATION
generators/fax/CMakeLists.txt f3a321c
generators/fax/okular-fax.metainfo.xml PRE-CREATION
generators/fictionbook/CMakeLists.txt 108568b
generators/fictionbook/okular-fb.metainfo.xml PRE-CREATION
shell/CMakeLists.txt d51cc7e
shell/org.kde.okular.appdata.xml PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/128404/diff/
Testing
-------
builds
Thanks,
Burkhard LÃŒck
Matthias Klumpp
2016-11-01 19:00:50 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128404/#review100482
-----------------------------------------------------------




shell/org.kde.okular.appdata.xml (line 3)
<https://git.reviewboard.kde.org/r/128404/#comment67429>

Is the .desktop file not named `org.kde.okular.desktop`? If so, consider renaming it.
Ideally the metainfo filename should follow the .desktop filename, but that's not a fixed requirement (and it's even a better idea to keep the metainfo filename in the reverse-DNS scheme in case the .desktop file is renamed later).



shell/org.kde.okular.appdata.xml (line 29)
<https://git.reviewboard.kde.org/r/128404/#comment67430>

Super picky: The indentation here is slightly off ;-)


- Matthias Klumpp
Post by Burkhard Lück
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/128404/
-----------------------------------------------------------
(Updated Nov. 1, 2016, 6:20 p.m.)
Review request for KDE Graphics, Albert Astals Cid and Matthias Klumpp.
Repository: okular
Description
-------
verified with appstreamcli validate
Diffs
-----
generators/chm/CMakeLists.txt e54affc
generators/chm/okular-chm.metainfo.xml PRE-CREATION
generators/comicbook/CMakeLists.txt 4df23a6
generators/comicbook/okular-comicbook.metainfo.xml PRE-CREATION
generators/djvu/CMakeLists.txt 8ca545c
generators/djvu/okular-djvu.metainfo.xml PRE-CREATION
generators/dvi/CMakeLists.txt e95c9ca
generators/dvi/okular-dvi.metainfo.xml PRE-CREATION
generators/epub/CMakeLists.txt fa989ad
generators/epub/okular-epub.metainfo.xml PRE-CREATION
generators/fax/CMakeLists.txt f3a321c
generators/fax/okular-fax.metainfo.xml PRE-CREATION
generators/fictionbook/CMakeLists.txt 108568b
generators/fictionbook/okular-fb.metainfo.xml PRE-CREATION
shell/CMakeLists.txt d51cc7e
shell/org.kde.okular.appdata.xml PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/128404/diff/
Testing
-------
builds
Thanks,
Burkhard LÃŒck
Burkhard Lück
2016-11-02 13:55:08 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128404/
-----------------------------------------------------------

(Updated Nov. 2, 2016, 1:55 nachm.)


Review request for KDE Graphics, Albert Astals Cid and Matthias Klumpp.


Changes
-------

use org.kde.okular.desktop als <id> and fix wrong indentation
I'll commit this to master, when the frameworks branch is merged and rename the okular.desktop file and translations accordingly


Repository: okular


Description
-------

verified with appstreamcli validate


Diffs (updated)
-----

generators/chm/CMakeLists.txt e54affc
generators/chm/okular-chm.metainfo.xml PRE-CREATION
generators/comicbook/CMakeLists.txt 4df23a6
generators/comicbook/okular-comicbook.metainfo.xml PRE-CREATION
generators/djvu/CMakeLists.txt 8ca545c
generators/djvu/okular-djvu.metainfo.xml PRE-CREATION
generators/dvi/CMakeLists.txt e95c9ca
generators/dvi/okular-dvi.metainfo.xml PRE-CREATION
generators/epub/CMakeLists.txt fa989ad
generators/epub/okular-epub.metainfo.xml PRE-CREATION
generators/fax/CMakeLists.txt f3a321c
generators/fax/okular-fax.metainfo.xml PRE-CREATION
generators/fictionbook/CMakeLists.txt 108568b
generators/fictionbook/okular-fb.metainfo.xml PRE-CREATION
shell/CMakeLists.txt d51cc7e
shell/org.kde.okular.appdata.xml PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/128404/diff/


Testing
-------

builds


Thanks,

Burkhard LÃŒck
Matthias Klumpp
2016-11-03 01:46:30 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128404/#review100527
-----------------------------------------------------------


Ship it!




Sounds very good :-)

- Matthias Klumpp
Post by Burkhard Lück
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/128404/
-----------------------------------------------------------
(Updated Nov. 2, 2016, 1:55 p.m.)
Review request for KDE Graphics, Albert Astals Cid and Matthias Klumpp.
Repository: okular
Description
-------
verified with appstreamcli validate
Diffs
-----
generators/chm/CMakeLists.txt e54affc
generators/chm/okular-chm.metainfo.xml PRE-CREATION
generators/comicbook/CMakeLists.txt 4df23a6
generators/comicbook/okular-comicbook.metainfo.xml PRE-CREATION
generators/djvu/CMakeLists.txt 8ca545c
generators/djvu/okular-djvu.metainfo.xml PRE-CREATION
generators/dvi/CMakeLists.txt e95c9ca
generators/dvi/okular-dvi.metainfo.xml PRE-CREATION
generators/epub/CMakeLists.txt fa989ad
generators/epub/okular-epub.metainfo.xml PRE-CREATION
generators/fax/CMakeLists.txt f3a321c
generators/fax/okular-fax.metainfo.xml PRE-CREATION
generators/fictionbook/CMakeLists.txt 108568b
generators/fictionbook/okular-fb.metainfo.xml PRE-CREATION
shell/CMakeLists.txt d51cc7e
shell/org.kde.okular.appdata.xml PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/128404/diff/
Testing
-------
builds
Thanks,
Burkhard LÃŒck
Burkhard Lück
2016-11-04 13:57:40 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128404/
-----------------------------------------------------------

(Updated Nov. 4, 2016, 1:57 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Graphics, Albert Astals Cid and Matthias Klumpp.


Changes
-------

Submitted with commit 8666cacb926ab473bb1dc9025f2e9ebb5786c3af by Burkhard LÃŒck to branch master.


Repository: okular


Description
-------

verified with appstreamcli validate


Diffs
-----

generators/chm/CMakeLists.txt e54affc
generators/chm/okular-chm.metainfo.xml PRE-CREATION
generators/comicbook/CMakeLists.txt 4df23a6
generators/comicbook/okular-comicbook.metainfo.xml PRE-CREATION
generators/djvu/CMakeLists.txt 8ca545c
generators/djvu/okular-djvu.metainfo.xml PRE-CREATION
generators/dvi/CMakeLists.txt e95c9ca
generators/dvi/okular-dvi.metainfo.xml PRE-CREATION
generators/epub/CMakeLists.txt fa989ad
generators/epub/okular-epub.metainfo.xml PRE-CREATION
generators/fax/CMakeLists.txt f3a321c
generators/fax/okular-fax.metainfo.xml PRE-CREATION
generators/fictionbook/CMakeLists.txt 108568b
generators/fictionbook/okular-fb.metainfo.xml PRE-CREATION
shell/CMakeLists.txt d51cc7e
shell/org.kde.okular.appdata.xml PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/128404/diff/


Testing
-------

builds


Thanks,

Burkhard LÃŒck

Continue reading on narkive:
Loading...