Discussion:
Review Request 129151: Don't use native color picker
Antonio Rojas
2016-10-11 17:23:17 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129151/
-----------------------------------------------------------

Review request for KDE Graphics.


Repository: kcolorchooser


Description
-------

kcolorchooser fails to run in GTK desktops, since it tries to embed the native GTK color picker instead of the Qt one. This forces it to use the Qt dialog.


Diffs
-----

kcolorchooser.cpp 9488b62

Diff: https://git.reviewboard.kde.org/r/129151/diff/


Testing
-------

kcolorchooser runs in XFCE


Thanks,

Antonio Rojas
Albert Astals Cid
2016-10-11 21:32:00 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129151/#review99943
-----------------------------------------------------------



If nobody gives you a ship it before 2 weeks, consider this a ship it from my side.

- Albert Astals Cid
Post by Antonio Rojas
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129151/
-----------------------------------------------------------
(Updated Oct. 11, 2016, 9:31 p.m.)
Review request for KDE Graphics and Christoph Feck.
Repository: kcolorchooser
Description
-------
kcolorchooser fails to run in GTK desktops, since it tries to embed the native GTK color picker instead of the Qt one. This forces it to use the Qt dialog.
Diffs
-----
kcolorchooser.cpp 9488b62
Diff: https://git.reviewboard.kde.org/r/129151/diff/
Testing
-------
kcolorchooser runs in XFCE
Thanks,
Antonio Rojas
Aleix Pol Gonzalez
2016-10-11 21:32:59 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129151/#review99944
-----------------------------------------------------------


Ship it!




Isn't it an error in Qt then?

+1 anyway, because I tried and indeed it does nothing at the moment.

- Aleix Pol Gonzalez
Post by Antonio Rojas
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129151/
-----------------------------------------------------------
(Updated Oct. 11, 2016, 11:31 p.m.)
Review request for KDE Graphics and Christoph Feck.
Repository: kcolorchooser
Description
-------
kcolorchooser fails to run in GTK desktops, since it tries to embed the native GTK color picker instead of the Qt one. This forces it to use the Qt dialog.
Diffs
-----
kcolorchooser.cpp 9488b62
Diff: https://git.reviewboard.kde.org/r/129151/diff/
Testing
-------
kcolorchooser runs in XFCE
Thanks,
Antonio Rojas
Antonio Rojas
2016-10-12 08:00:56 UTC
Permalink
Post by Antonio Rojas
Post by Aleix Pol Gonzalez
Isn't it an error in Qt then?
+1 anyway, because I tried and indeed it does nothing at the moment.
I don't think so, kcolorchooser asks for a QColorDialog and Qt returns the native one as expected. Whatever happens next is not Qt's fault.


- Antonio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129151/#review99944
-----------------------------------------------------------
Post by Antonio Rojas
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129151/
-----------------------------------------------------------
(Updated Oct. 11, 2016, 9:31 p.m.)
Review request for KDE Graphics and Christoph Feck.
Repository: kcolorchooser
Description
-------
kcolorchooser fails to run in GTK desktops, since it tries to embed the native GTK color picker instead of the Qt one. This forces it to use the Qt dialog.
Diffs
-----
kcolorchooser.cpp 9488b62
Diff: https://git.reviewboard.kde.org/r/129151/diff/
Testing
-------
kcolorchooser runs in XFCE
Thanks,
Antonio Rojas
Aleix Pol Gonzalez
2016-10-12 23:37:59 UTC
Permalink
Post by Antonio Rojas
Post by Aleix Pol Gonzalez
Isn't it an error in Qt then?
+1 anyway, because I tried and indeed it does nothing at the moment.
I don't think so, kcolorchooser asks for a QColorDialog and Qt returns the native one as expected. Whatever happens next is not Qt's fault.
Note that all platform themes except for Plasma's are provided by Qt itself, so if it doesn't work on Gnome/XFCE it's because over there the QPT is doing something weird.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129151/#review99944
-----------------------------------------------------------
Post by Antonio Rojas
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129151/
-----------------------------------------------------------
(Updated Oct. 12, 2016, 10:04 a.m.)
Review request for KDE Graphics and Christoph Feck.
Repository: kcolorchooser
Description
-------
kcolorchooser fails to run in GTK desktops, since it tries to embed the native GTK color picker instead of the Qt one. This forces it to use the Qt dialog.
Diffs
-----
kcolorchooser.cpp 9488b62
Diff: https://git.reviewboard.kde.org/r/129151/diff/
Testing
-------
kcolorchooser runs in XFCE
Thanks,
Antonio Rojas
Antonio Rojas
2016-10-13 09:27:36 UTC
Permalink
Post by Antonio Rojas
Post by Aleix Pol Gonzalez
Isn't it an error in Qt then?
+1 anyway, because I tried and indeed it does nothing at the moment.
I don't think so, kcolorchooser asks for a QColorDialog and Qt returns the native one as expected. Whatever happens next is not Qt's fault.
Note that all platform themes except for Plasma's are provided by Qt itself, so if it doesn't work on Gnome/XFCE it's because over there the QPT is doing something weird.
No, Qt is working as intended, by returning the GTK dialog. The problem is that kcolorchooser can't handle it (specifically: it can't add a help button to the QDialogButtonBox because there is no QDialogButtonBox at all, see lines 74 and next in kcolorchooser.cpp)


- Antonio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129151/#review99944
-----------------------------------------------------------
Post by Antonio Rojas
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129151/
-----------------------------------------------------------
(Updated Oct. 12, 2016, 8:04 a.m.)
Review request for KDE Graphics and Christoph Feck.
Repository: kcolorchooser
Description
-------
kcolorchooser fails to run in GTK desktops, since it tries to embed the native GTK color picker instead of the Qt one. This forces it to use the Qt dialog.
Diffs
-----
kcolorchooser.cpp 9488b62
Diff: https://git.reviewboard.kde.org/r/129151/diff/
Testing
-------
kcolorchooser runs in XFCE
Thanks,
Antonio Rojas
Antonio Rojas
2016-10-12 08:04:19 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129151/
-----------------------------------------------------------

(Updated Oct. 12, 2016, 8:04 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Graphics and Christoph Feck.


Changes
-------

Submitted with commit 1f35c6d3dffbdfbbd7679e6b9a6297bd421abb3e by Antonio Rojas to branch Applications/16.08.


Repository: kcolorchooser


Description
-------

kcolorchooser fails to run in GTK desktops, since it tries to embed the native GTK color picker instead of the Qt one. This forces it to use the Qt dialog.


Diffs
-----

kcolorchooser.cpp 9488b62

Diff: https://git.reviewboard.kde.org/r/129151/diff/


Testing
-------

kcolorchooser runs in XFCE


Thanks,

Antonio Rojas
Christoph Feck
2016-10-12 13:50:23 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129151/#review99956
-----------------------------------------------------------
Post by Antonio Rojas
kcolorchooser fails
Can you check other KDE applications that use QColorDialog, e.g. KolourPaint? I would hate to make applications force the native Qt dialog, just because some Qt integration fails.

- Christoph Feck
Post by Antonio Rojas
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129151/
-----------------------------------------------------------
(Updated Oct. 12, 2016, 10:04 a.m.)
Review request for KDE Graphics and Christoph Feck.
Repository: kcolorchooser
Description
-------
kcolorchooser fails to run in GTK desktops, since it tries to embed the native GTK color picker instead of the Qt one. This forces it to use the Qt dialog.
Diffs
-----
kcolorchooser.cpp 9488b62
Diff: https://git.reviewboard.kde.org/r/129151/diff/
Testing
-------
kcolorchooser runs in XFCE
Thanks,
Antonio Rojas
Antonio Rojas
2016-10-12 13:54:55 UTC
Permalink
Post by Antonio Rojas
Post by Christoph Feck
Post by Antonio Rojas
kcolorchooser fails
Can you check other KDE applications that use QColorDialog, e.g. KolourPaint? I would hate to make applications force the native Qt dialog, just because some Qt integration fails.
Yes, the color picker works fine in all other applications and uses the native one for the running DE. The problem is only with kcolorchooser, where the application *is* the color picker.


- Antonio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129151/#review99956
-----------------------------------------------------------
Post by Antonio Rojas
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129151/
-----------------------------------------------------------
(Updated Oct. 12, 2016, 8:04 a.m.)
Review request for KDE Graphics and Christoph Feck.
Repository: kcolorchooser
Description
-------
kcolorchooser fails to run in GTK desktops, since it tries to embed the native GTK color picker instead of the Qt one. This forces it to use the Qt dialog.
Diffs
-----
kcolorchooser.cpp 9488b62
Diff: https://git.reviewboard.kde.org/r/129151/diff/
Testing
-------
kcolorchooser runs in XFCE
Thanks,
Antonio Rojas
Loading...