Discussion:
Review Request 129568: Change strings to address i18n issues
Peter Wu
2016-11-27 12:10:06 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129568/
-----------------------------------------------------------

Review request for KDE Graphics, Albert Astals Cid and Boudhayan Gupta.


Repository: spectacle


Description
-------

Change "Preferences" to "Configure" (window title) and "Configure
Spectacle..." (menu action). Add ellipsis when possible.

Add TODO comment for inconsistent use of "screen" and "monitors", this
requires more changes beyond changing text.


Diffs
-----

doc/index.docbook 5ad5ef08d8834d4b8ac982ea5c1c928cdac5ecab
src/Gui/ExportMenu.cpp 4b894c7d991140f08912a90eb41571108439264b
src/Gui/KSMainWindow.cpp 5a4dd77564e98b961adcadcec18e5d5fad4d4bb4
src/Gui/KSWidget.cpp 380bff6809131477446aaecb947c2d7b7dde3289
src/Gui/SettingsDialog/SettingsDialog.cpp 7cfe8e2ca676a414d7a84a20b134b2e1ae89a9b3
src/Gui/SmartSpinBox.cpp 4938f84f62b194fcbd2461915e628dfb45c4abb4

Diff: https://git.reviewboard.kde.org/r/129568/diff/


Testing
-------

Checked text under Save menu, Configure dialog.


Thanks,

Peter Wu
Boudhayan Gupta
2016-11-27 13:35:46 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129568/#review101136
-----------------------------------------------------------



I'll let Albert have full authority over this review.

- Boudhayan Gupta
Post by Peter Wu
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129568/
-----------------------------------------------------------
(Updated Nov. 27, 2016, 5:40 p.m.)
Review request for KDE Graphics, Albert Astals Cid and Boudhayan Gupta.
Repository: spectacle
Description
-------
Change "Preferences" to "Configure" (window title) and "Configure
Spectacle..." (menu action). Add ellipsis when possible.
Add TODO comment for inconsistent use of "screen" and "monitors", this
requires more changes beyond changing text.
Diffs
-----
doc/index.docbook 5ad5ef08d8834d4b8ac982ea5c1c928cdac5ecab
src/Gui/ExportMenu.cpp 4b894c7d991140f08912a90eb41571108439264b
src/Gui/KSMainWindow.cpp 5a4dd77564e98b961adcadcec18e5d5fad4d4bb4
src/Gui/KSWidget.cpp 380bff6809131477446aaecb947c2d7b7dde3289
src/Gui/SettingsDialog/SettingsDialog.cpp 7cfe8e2ca676a414d7a84a20b134b2e1ae89a9b3
src/Gui/SmartSpinBox.cpp 4938f84f62b194fcbd2461915e628dfb45c4abb4
Diff: https://git.reviewboard.kde.org/r/129568/diff/
Testing
-------
Checked text under Save menu, Configure dialog.
Thanks,
Peter Wu
Albert Astals Cid
2016-11-27 22:57:45 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129568/#review101145
-----------------------------------------------------------




src/Gui/KSMainWindow.cpp (line 225)
<https://git.reviewboard.kde.org/r/129568/#comment67785>

Any reason not to use KStandardAction::preferences ?



src/Gui/SettingsDialog/SettingsDialog.cpp (line 36)
<https://git.reviewboard.kde.org/r/129568/#comment67787>

Can you try if you can just use a KConfigDialog instead of a KPageDialog and then this translation comes in for free?



src/Gui/SmartSpinBox.cpp (line 42)
<https://git.reviewboard.kde.org/r/129568/#comment67786>

You say you can not use i18np and the go and use i18np?


- Albert Astals Cid
Post by Peter Wu
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129568/
-----------------------------------------------------------
(Updated Nov. 27, 2016, 12:10 p.m.)
Review request for KDE Graphics, Albert Astals Cid and Boudhayan Gupta.
Repository: spectacle
Description
-------
Change "Preferences" to "Configure" (window title) and "Configure
Spectacle..." (menu action). Add ellipsis when possible.
Add TODO comment for inconsistent use of "screen" and "monitors", this
requires more changes beyond changing text.
Diffs
-----
doc/index.docbook 5ad5ef08d8834d4b8ac982ea5c1c928cdac5ecab
src/Gui/ExportMenu.cpp 4b894c7d991140f08912a90eb41571108439264b
src/Gui/KSMainWindow.cpp 5a4dd77564e98b961adcadcec18e5d5fad4d4bb4
src/Gui/KSWidget.cpp 380bff6809131477446aaecb947c2d7b7dde3289
src/Gui/SettingsDialog/SettingsDialog.cpp 7cfe8e2ca676a414d7a84a20b134b2e1ae89a9b3
src/Gui/SmartSpinBox.cpp 4938f84f62b194fcbd2461915e628dfb45c4abb4
Diff: https://git.reviewboard.kde.org/r/129568/diff/
Testing
-------
Checked text under Save menu, Configure dialog.
Thanks,
Peter Wu
Peter Wu
2016-12-06 18:50:47 UTC
Permalink
Post by Peter Wu
src/Gui/KSMainWindow.cpp, line 225
<https://git.reviewboard.kde.org/r/129568/diff/1/?file=486714#file486714line225>
Any reason not to use KStandardAction::preferences ?
Currently it shows a Spectacle icon before the text, but I think it is OK dropping it. Will change it.
Post by Peter Wu
src/Gui/SmartSpinBox.cpp, line 42
<https://git.reviewboard.kde.org/r/129568/diff/1/?file=486717#file486717line42>
You say you can not use i18np and the go and use i18np?
Remnant of the previous patch, will fix it.
Post by Peter Wu
src/Gui/SettingsDialog/SettingsDialog.cpp, line 36
<https://git.reviewboard.kde.org/r/129568/diff/1/?file=486716#file486716line36>
Can you try if you can just use a KConfigDialog instead of a KPageDialog and then this translation comes in for free?
This seems to require more changes. showPreferencesDialog in `src/Gui/KSMainWindow.cpp` should probably be modified according to https://api.kde.org/frameworks/kconfigwidgets/html/classKConfigDialog.html#details

SpectacleConfig is also a QObject and not a KConfigSkeleton, it will be more work to adapt to that API so I will leave it unchanged for now.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129568/#review101145
-----------------------------------------------------------
Post by Peter Wu
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129568/
-----------------------------------------------------------
(Updated Nov. 27, 2016, 1:10 p.m.)
Review request for KDE Graphics, Albert Astals Cid and Boudhayan Gupta.
Repository: spectacle
Description
-------
Change "Preferences" to "Configure" (window title) and "Configure
Spectacle..." (menu action). Add ellipsis when possible.
Add TODO comment for inconsistent use of "screen" and "monitors", this
requires more changes beyond changing text.
Diffs
-----
doc/index.docbook 5ad5ef08d8834d4b8ac982ea5c1c928cdac5ecab
src/Gui/ExportMenu.cpp 4b894c7d991140f08912a90eb41571108439264b
src/Gui/KSMainWindow.cpp 5a4dd77564e98b961adcadcec18e5d5fad4d4bb4
src/Gui/KSWidget.cpp 380bff6809131477446aaecb947c2d7b7dde3289
src/Gui/SettingsDialog/SettingsDialog.cpp 7cfe8e2ca676a414d7a84a20b134b2e1ae89a9b3
src/Gui/SmartSpinBox.cpp 4938f84f62b194fcbd2461915e628dfb45c4abb4
Diff: https://git.reviewboard.kde.org/r/129568/diff/
Testing
-------
Checked text under Save menu, Configure dialog.
Thanks,
Peter Wu
Albert Astals Cid
2016-12-05 22:02:36 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129568/#review101306
-----------------------------------------------------------



ping?

- Albert Astals Cid
Post by Peter Wu
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129568/
-----------------------------------------------------------
(Updated Nov. 27, 2016, 12:10 p.m.)
Review request for KDE Graphics, Albert Astals Cid and Boudhayan Gupta.
Repository: spectacle
Description
-------
Change "Preferences" to "Configure" (window title) and "Configure
Spectacle..." (menu action). Add ellipsis when possible.
Add TODO comment for inconsistent use of "screen" and "monitors", this
requires more changes beyond changing text.
Diffs
-----
doc/index.docbook 5ad5ef08d8834d4b8ac982ea5c1c928cdac5ecab
src/Gui/ExportMenu.cpp 4b894c7d991140f08912a90eb41571108439264b
src/Gui/KSMainWindow.cpp 5a4dd77564e98b961adcadcec18e5d5fad4d4bb4
src/Gui/KSWidget.cpp 380bff6809131477446aaecb947c2d7b7dde3289
src/Gui/SettingsDialog/SettingsDialog.cpp 7cfe8e2ca676a414d7a84a20b134b2e1ae89a9b3
src/Gui/SmartSpinBox.cpp 4938f84f62b194fcbd2461915e628dfb45c4abb4
Diff: https://git.reviewboard.kde.org/r/129568/diff/
Testing
-------
Checked text under Save menu, Configure dialog.
Thanks,
Peter Wu
Peter Wu
2016-12-06 18:53:10 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129568/
-----------------------------------------------------------

(Updated Dec. 6, 2016, 7:53 p.m.)


Review request for KDE Graphics and Boudhayan Gupta.


Repository: spectacle


Description (updated)
-------

Change strings to address i18n issues

Change "Preferences" to "Configure" (window title) and use a
KStandardAction::preferences item (and get the "Configure Spectacle..."
text for free).

Add TODO comment for inconsistent use of "screen" and "monitors", this
requires more changes beyond changing text.


Diffs (updated)
-----

doc/index.docbook 5ad5ef08d8834d4b8ac982ea5c1c928cdac5ecab
src/Gui/ExportMenu.cpp 4b894c7d991140f08912a90eb41571108439264b
src/Gui/KSMainWindow.cpp 5a4dd77564e98b961adcadcec18e5d5fad4d4bb4
src/Gui/KSWidget.cpp 380bff6809131477446aaecb947c2d7b7dde3289
src/Gui/SettingsDialog/SettingsDialog.cpp 7cfe8e2ca676a414d7a84a20b134b2e1ae89a9b3
src/Gui/SmartSpinBox.cpp 4938f84f62b194fcbd2461915e628dfb45c4abb4

Diff: https://git.reviewboard.kde.org/r/129568/diff/


Testing (updated)
-------

Checked text under Save menu (icon has also changed), Configure dialog.


Thanks,

Peter Wu

Loading...