Discussion:
Review Request 129322: add appstream file to kruler
Harald Sitter
2016-11-03 14:30:09 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129322/
-----------------------------------------------------------

Review request for KDE Graphics.


Repository: kruler


Description
-------

this breaks string freeze, but is necessary to get kruler to appear in
appstream-driven software stores.

CCMAIL: kde-i18n-***@kde.org


Diffs
-----

CMakeLists.txt 85947e3cf2d9386b8ea9cec7da404d301faa0b66
org.kde.kruler.appdata.xml PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/129322/diff/


Testing
-------

installs & validates


Thanks,

Harald Sitter
Aleix Pol Gonzalez
2016-11-03 14:38:10 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129322/#review100539
-----------------------------------------------------------



+1

- Aleix Pol Gonzalez
Post by Harald Sitter
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129322/
-----------------------------------------------------------
(Updated Nov. 3, 2016, 3:30 p.m.)
Review request for KDE Graphics.
Repository: kruler
Description
-------
this breaks string freeze, but is necessary to get kruler to appear in
appstream-driven software stores.
Diffs
-----
CMakeLists.txt 85947e3cf2d9386b8ea9cec7da404d301faa0b66
org.kde.kruler.appdata.xml PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/129322/diff/
Testing
-------
installs & validates
Thanks,
Harald Sitter
Albert Astals Cid
2016-11-07 23:07:48 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129322/#review100699
-----------------------------------------------------------



Given the last version of Applications/16.08 is being tagged in around 53 minutes i suggest you discard this and just commit to master.

- Albert Astals Cid
Post by Harald Sitter
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129322/
-----------------------------------------------------------
(Updated Nov. 7, 2016, 4:24 p.m.)
Review request for KDE Graphics and Localization and Translation (l10n).
Repository: kruler
Description
-------
this breaks string freeze, but is necessary to get kruler to appear in
appstream-driven software stores.
Diffs
-----
CMakeLists.txt 85947e3cf2d9386b8ea9cec7da404d301faa0b66
org.kde.kruler.appdata.xml PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/129322/diff/
Testing
-------
installs & validates
Thanks,
Harald Sitter
Harald Sitter
2016-11-08 09:28:37 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129322/
-----------------------------------------------------------

(Updated Nov. 8, 2016, 9:28 a.m.)


Review request for KDE Graphics and Localization and Translation (l10n).


Changes
-------

targeting master now


Repository: kruler


Description (updated)
-------

this is necessary to get kcalc to appear in appstream-driven software stores.


Diffs
-----

CMakeLists.txt 85947e3cf2d9386b8ea9cec7da404d301faa0b66
org.kde.kruler.appdata.xml PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/129322/diff/


Testing
-------

installs & validates


Thanks,

Harald Sitter
Aleix Pol Gonzalez
2016-11-08 11:19:06 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129322/#review100709
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez
Post by Harald Sitter
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129322/
-----------------------------------------------------------
(Updated Nov. 8, 2016, 10:28 a.m.)
Review request for KDE Graphics and Localization and Translation (l10n).
Repository: kruler
Description
-------
this is necessary to get kcalc to appear in appstream-driven software stores.
Diffs
-----
CMakeLists.txt 85947e3cf2d9386b8ea9cec7da404d301faa0b66
org.kde.kruler.appdata.xml PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/129322/diff/
Testing
-------
installs & validates
Thanks,
Harald Sitter
Harald Sitter
2016-11-09 11:19:52 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129322/
-----------------------------------------------------------

(Updated Nov. 9, 2016, 12:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Graphics and Localization and Translation (l10n).


Changes
-------

Submitted with commit d05fab8bed69f073c3ec25afb2d87046eb7ad09a by Harald Sitter to branch master.


Repository: kruler


Description
-------

this is necessary to get kcalc to appear in appstream-driven software stores.


Diffs
-----

CMakeLists.txt 85947e3cf2d9386b8ea9cec7da404d301faa0b66
org.kde.kruler.appdata.xml PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/129322/diff/


Testing
-------

installs & validates


Thanks,

Harald Sitter

Loading...